-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 10.1 throws Error: The provided value is non-finite #364
Comments
cue.line = 'auto'
and cue.position = 'auto'
Here's what we do in jwplayer:
|
Here's how we worked around it: const oldVTTCue = global.VTTCue;
try {
global.VTTCue = VTTCue;
parser.parse(vtt);
parser.flush();
} finally {
global.VTTCue = oldVTTCue;
} The VTTCue in scope is the one from vtt.js |
The spec clearly allows for Apple's native VTTCue is not spec compliant. |
Agreed, but why not solving it in the polyfill?
|
Use the default value for line if set, otherwise use 'auto'.
Thanks, |
I added position to my PR |
Apparently the travis build failed with that change... :/ position wasn't 'auto'? |
Ugh... apparently that breaks the tests. cue.position is auto by default (in chrome & ff...in safari its 50) and I'm just using the default if set... and falling back to what was there... :/ |
Im using |
This is not really resolved yet... |
my PR should fix it |
Oops wrong button! |
Hi, is there any progress on this? Or maybe a workaround? |
Just waiting for the pr to be merged. |
We are still getting this issue in Safari 13.0.3 (15608.3.10.1.4). Any news on the PR being merged? |
I believe this is fixed or will soon (in the next release) be fixed in the videojs fork of vtt.js. It's probably the only currently maintained version of vtt.js: https://github.com/videojs/vtt.js (videojs-vtt.js on npm) |
When using vtt.js in Safari it throws
Error: The provided value is non-finite
on this partcue.line = settings.get("line", "auto");
.I think this is an issue in the Safari VTTCue implementation, but I hope to find a workaround in this polyfill.
Below the stacktrace:
The text was updated successfully, but these errors were encountered: