Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reap PR added methods but didn't bump the version #191

Open
iain-bryson opened this issue Aug 10, 2024 · 0 comments
Open

The reap PR added methods but didn't bump the version #191

iain-bryson opened this issue Aug 10, 2024 · 0 comments

Comments

@iain-bryson
Copy link

iain-bryson commented Aug 10, 2024

https://github.com/mperham/connection_pool/pull/187/files added methods like idle but didn't bump the version so there's no way to specify a connection_pool gem with the reap functionality without resorting to github SHA:

irb(main):004:0> cp = ConnectionPool.new { {foo: 'bar'} }
=> #<ConnectionPool:0x00007f9b31059118 @size=5, @timeout=5, @auto_reload_after_fork=true, @available=#
irb(main):005:0> cp.idle
NoMethodError (undefined method `idle' for #<ConnectionPool:0x00007f9b31059118>)
irb(main):006:0> ConnectionPool::VERSION
=> "2.4.1"

Is there a timeline for publishing a version of the gem with this change to RubyGems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant