Start of 3D plots: Basic plot_surface #201
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick first pass at implementing
plot_surface
using theartist.remove
strategy from #89 (comment)attn: @redeboer this is a rough starting place. If you'd like to work on this you're absolutely welcome to work starting off this branch. I probably will only work on this in occasional spurts as it isn't a pressing need for me. So if you aren't able to work on this but it's something you'd like to be able to use then I'd also be open to releasing it before I clean up having all the arguments be callable and other polish.
One thing I didn't realize previously is that we have to do some shenanigans with the color cycles in order to get the color to stay the same.
See also: t-makaro/animatplot#57 by @johnomotani
TODO:
Y
is a callable is must acceptX
as an argument. This probably shouldn't be a hard requirement.Final thought: Rewriting the
vmin_vmax
code for the Nth time has me really thinking that perhaps this function approach wasn't really the best. Maybe I should have made my own artist type objects that know how to update themselves. So then there could be aHasNorm
class that handles all thevmin_vmax
stuff in one place.