Windows pascal macro strikes again

[CrustyAuklet]

I am very sorry to report that in my transition to V2 I am hitting the pascal macro as reported in #459.

My embedded SDK has a "units.hpp" header where I include the mp-units code, and the only includes are:

#include <mp-units/systems/si.h>
#include <mp-units/systems/iec80000.h>
#include <cnl/fixed_point.h>

I get the macro error in the header systems/include/mp-units/systems/si/unit_symbols.h

mp-units/src/systems/include/mp-units/systems/si/unit_symbols.h

Lines 321 to 345 in 77625d6

	inline constexpr auto qPa = quecto<pascal>;
	inline constexpr auto rPa = ronto<pascal>;
	inline constexpr auto yPa = yocto<pascal>;
	inline constexpr auto zPa = zepto<pascal>;
	inline constexpr auto aPa = atto<pascal>;
	inline constexpr auto fPa = femto<pascal>;
	inline constexpr auto pPa = pico<pascal>;
	inline constexpr auto nPa = nano<pascal>;
	inline constexpr auto uPa = micro<pascal>;
	inline constexpr auto mPa = milli<pascal>;
	inline constexpr auto cPa = centi<pascal>;
	inline constexpr auto dPa = deci<pascal>;
	inline constexpr auto Pa = pascal;
	inline constexpr auto daPa = deca<pascal>;
	inline constexpr auto hPa = hecto<pascal>;
	inline constexpr auto kPa = kilo<pascal>;
	inline constexpr auto MPa = mega<pascal>;
	inline constexpr auto GPa = giga<pascal>;
	inline constexpr auto TPa = tera<pascal>;
	inline constexpr auto PPa = peta<pascal>;
	inline constexpr auto EPa = exa<pascal>;
	inline constexpr auto ZPa = zetta<pascal>;
	inline constexpr auto YPa = yotta<pascal>;
	inline constexpr auto RPa = ronna<pascal>;
	inline constexpr auto QPa = quetta<pascal>;

Compiler: clang-cl-18
platform: Windows 10

[connorjak]

Related:

• All-units prebuilt header error on pascal on MSVC aurora-opensource/au#284

#undef pascal seems to be the fix to do, in user code right before including mp-units.

Though, from this search, it seems it might already be done? https://github.com/search?q=repo%3Ampusz%2Fmp-units+pascal&type=code

[CrustyAuklet]

Though, from this search, it seems it might already be done? https://github.com/search?q=repo%3Ampusz%2Fmp-units+pascal&type=code

#undef pascal is in the header src/systems/include/mp-units/systems/si/units.h as a fix for #459.

But the header src/systems/include/mp-units/systems/si/unit_symbols.h also uses the name pascal and so also needs the same fix applied around the block of pascal unit symbols.

As a workaround I am un-defining pascal before including the mp-units headers, but since the fix was done in the library for the one instance it seems like the other should also be addressed in the library.