Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of eval() in UnitTestFramework.brs breaks with OS 9.3 #22

Open
bbonet-entercom opened this issue May 19, 2020 · 3 comments
Open

Use of eval() in UnitTestFramework.brs breaks with OS 9.3 #22

bbonet-entercom opened this issue May 19, 2020 · 3 comments

Comments

@bbonet-entercom
Copy link

OS 9.3 Any apps using this framework will not load. Your app will be broken. As this framework was used on our current roku app, our quick solution was to just comment the two eval() lines out. Obviously this is not good for unit testing, but it's a quick way to re-submit your app and getting it running again in the short term.

@mrkjffrsn
Copy link
Owner

Thank you for noting this. The eval expression is used within the Roku unit test framework. Roku has released a new version of their unit testframework that does not use eval. Updating the unit test framework to the latest one should fix this.

I'll have a patch fix for it soon.

@bbonet-entercom
Copy link
Author

Thanks. I didn't realize it was the official testing framework (I'm a newb). I replaced it with the latest and problem solved. Thanks! Looking forward to that update still!

@mrkjffrsn
Copy link
Owner

@bbonet-entercom @jfrux as updated the unit test framework. I've left some comments on where you can find on porting all the test cases to work with the new framework. I'll push another update porting the existing test cases on the framework here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants