Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format (and position?) of adornments #46

Open
lasidolasido opened this issue Apr 4, 2024 · 6 comments
Open

Change format (and position?) of adornments #46

lasidolasido opened this issue Apr 4, 2024 · 6 comments
Milestone

Comments

@lasidolasido
Copy link

Your project seems really impressive. However, I find the resource content displayed over the resources in the editor a bit visually cluttered and not very user-friendly. I have a small suggestion, and I'd be really satisfied if you, being competent as you are, could update it accordingly.

before
image

after
image

@lasidolasido
Copy link
Author

append idea is font size change and font color
is best!!!!

@lasidolasido
Copy link
Author

This idea hasn't been terminated. Please take care of the idea.

@mrlacey
Copy link
Owner

mrlacey commented Apr 4, 2024

Your project seems really impressive. However, I find the resource content displayed over the resources in the editor a bit visually cluttered and not very user-friendly. I have a small suggestion, and I'd be really satisfied if you, being competent as you are, could update it accordingly.

before image

after image

What should happen here if the line contained multiple references to string resources?
They couldn't all be aligned to the left edge.
If immediately next to each other, how would they best be visually distinguished?
How should truncation work if some were very long?
How could it be made clear which reference in code represents which string?

@mrlacey
Copy link
Owner

mrlacey commented Apr 4, 2024

append idea is font size change and font color is best!!!!

It currently uses the size and color defined within the editor for displaying strings.
I thought it best to try and make it look as much like it would if you typed the string directly in code.

What's the reason for wanting to change this?
How would different be better?
Do you want to make it bigger or smaller?

@mrlacey mrlacey changed the title NEW IDEA Change format (and position?) of adornments Apr 4, 2024
@lasidolasido
Copy link
Author

lasidolasido commented Apr 4, 2024

Let me share my thoughts.

1,What should we do if there are multiple references to string resources on a line?

I hadn't considered the case of multiple references, but if there's only one, left-aligning would make the source editor look beautiful.
If there is more than one resource, left alignment should be ignored, or there should be another expression method.
It would also look good to use multiple lines with left-aligned resources in the order of resources. Your way of expression is more beautiful than comments.

2.Not everything can be aligned to the left edge.
This condition is included in item 1.
When there is only one resource on the line, left alignment is used.

3.How can they be visually distinguished best if they are right next to each other?
Similar to the question when there is more than one resource in item 1.
Options like TextTrimming with "..." and tooltip expressions could be considered. However, it may differ slightly from the developer's intention.
It doesn't force the expression to be above the resource. Once you get used to it, you can proficiently use it in any way.

4.How should truncation work if some are very long?
Similar question to when there is more than one resource in item 1.
It would be similar to the TextTrimming option in item 3.
Using multiple lines would also solve this problem to some extent.

5.How can we clearly know which reference in the code represents which string?
Similar question to when there is more than one resource in item 1.

P.S.: It works in comments too, which I really, really like.
I'm using attributes for multilingual support. It's perfect for me as it's expressed in comments."
image

Feel free to ask if you need further clarification or assistance!

@lasidolasido
Copy link
Author

The size of your expression and the actual size seem a bit different.
I am attaching the image below.
This was captured at 100% zoom.

image

@mrlacey mrlacey added this to the v2 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants