Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color diff between actual and expected row for column comparer #157

Merged
merged 3 commits into from
Sep 25, 2024
Merged

color diff between actual and expected row for column comparer #157

merged 3 commits into from
Sep 25, 2024

Conversation

zeotuan
Copy link
Collaborator

@zeotuan zeotuan commented Sep 16, 2024 •
edited
Loading

Now column diff are displayed this way. This is aligned with how we display diff for AssertSmallDatasetEquality which I think Improve readability.

image

@zeotuan zeotuan marked this pull request as ready for review September 18, 2024 11:55
@zeotuan zeotuan requested a review from alfonsorr September 18, 2024 11:55
SemyonSinchenko
SemyonSinchenko approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zeotuan zeotuan merged commit e49b44f into mrpowers-io:main Sep 25, 2024
6 checks passed
@zeotuan zeotuan linked an issue Sep 28, 2024 that may be closed by this pull request
Feature request - add string diff to test #136
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

@alfonsorr alfonsorr Awaiting requested review from alfonsorr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request - add string diff to test
2 participants
@zeotuan @SemyonSinchenko