From 29b20b1363428ce92670c218d56ea2ec19acdc55 Mon Sep 17 00:00:00 2001 From: Martin Smith Date: Wed, 6 Mar 2019 11:48:13 +0000 Subject: [PATCH] Update cran-comments.md --- cran-comments.md | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 052782e4..155944dc 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,12 +1,15 @@ +This release addresses the RNG issue flagged by Kurt Hornik as requiring an +immediate fix. + ## Test environments * local Windows 10 install, R 3.5.2 * win-builder, with `check_win_devel()` * Ubuntu 14.04.5 LTS, R 3.4 and devel, via [Travis CI](https://travis-ci.org/ms609/Quartet) -* R-hub, with `check_rhub(platforms = platforms())` +* R-hub, with `check_rhub(platforms = rhub::platforms())` * Installation failed with PREPERROR on rhub/ubuntu-gcc-release and rhub/fedora-clang-devel (and other platforms), on account of failures - to install a required dependency (`phangorn`). + to install a required dependencies. This seems to be an issue outside of my control. * Installation failed with ERROR on ubuntu-gcc-devel and debian-gcc-patched: > "there is no package called `lattice`" @@ -18,14 +21,24 @@ There were no ERRORs or WARNINGs. There was one NOTE: - > Days since last update: 6 +> Found the following (possibly) invalid URLs: +> URL: http://doi.org/10.2307/2413326 +> From: man/CompareQuartets.Rd +> man/CompareSplits.Rd +> man/QuartetState.Rd +> man/QuartetStatus.Rd +> man/SimilarityMetrics.Rd +> man/TQDist.Rd +> Status: 403 +> Message: Forbidden +> URL: http://doi.org/10.2307/2413347 +> From: man/SplitStatus.Rd +> Status: 403 +> Message: Forbidden -This release comes on the heels of v1.0.0 on 2019-01-16, which failed -certain CRAN package checks -- Brian Ripley requested that these be fixed -immediately and kindly proposed some suggestions for how portability could be -improved. -After implementing these and testing the relevant platforms using `check_rhub`, -I believe that the issues have been resolved. +These URLs are generated from DOIs in citations, and are valid. ## Downstream dependencies -There are currently no downstream dependencies for this package. + +The modifications only affect documentation objects and thus do not impact +the reverse dependency `CongreveLamsdell2016` (which I maintain).