Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot module #35

Open
17 of 23 tasks
mschubert opened this issue Feb 18, 2015 · 6 comments
Open
17 of 23 tasks

plot module #35

mschubert opened this issue Feb 18, 2015 · 6 comments

Comments

@mschubert
Copy link
Owner

mschubert commented Feb 18, 2015

Task list before merge into develop

Consider what's implemented in the ggfortify, GGally, ggdendro, ggRandomForests, and ggmcmc packages.

  • color
    • gradients
      • generating from color map
      • plotting of gradients
    • quantization
    • categorical
    • categorical + continuous
  • label
  • matrix
    • full
    • upper/lower triangular
  • heatmap
    • pheatmap interface that respects df conventions
  • venn
    • start from list of vectors
    • size-proportional
    • tree plots?
  • linear_fit
    • linear associations
    • p-value reporting
    • rsquared reporting
  • volcano
    • coloring according to effect direction and p-value
@klmr
Copy link
Contributor

klmr commented Feb 18, 2015

I’d like to avoid introducing inconsistencies if possible (don’t know what the status of this is). For instance, plotrix, heatmap.2 etc just do it objectively wrong.

We should try really, really hard to create APIs compatible with ggplot’s grammar of graphics, and with tidy data.

@mschubert
Copy link
Owner Author

We should try really, really hard to create APIs compatible with ggplot’s grammar of graphics, and with tidy data.

This is exactly what I'm trying to do.

However, there is things that ggplot2 can't easily do, like having the clustering tree next to the main plot. We'll have to find an acceptable solution for this. Options, as I see it, are (a) create an interface to pheatmap that takes the same structure as ggplot2 would and (b) teach ggplot2 about trees somehow.

@klmr
Copy link
Contributor

klmr commented Feb 18, 2015

There’s ggdendro. No idea how well that works. And I’ve just found plot_tree, which also looks interesting.

@mschubert
Copy link
Owner Author

ggally might also be something to look at

@barzine
Copy link
Contributor

barzine commented Feb 19, 2015

While you are working on this, can you also integer the options of heatmap3 (https://github.com/slzhao/heatmap3) for the annotation. Even, if I have to override some part of the function (and Nuno has also his own improved version) this package gives a nice overview of what I mean (http://www.biomedcentral.com/1471-2105/15/S10/P16/figure/F1)
(I have a start of something myself, but I never come around to finish it yet)

@jergosh
Copy link

jergosh commented Feb 19, 2015

Greg Jordan wrote some ggplot-based code for plotting trees for Phylosim,
if anyone feels like rolling their own and would like inspiration.

GregS

On Thu Feb 19 2015 at 10:08:32 AM M.P. Barzine [email protected]
wrote:

While you are working on this, can you also integer the options of
heatmap3 (https://github.com/slzhao/heatmap3) for the annotation. Even,
if I have to override some part of the function (and Nuno has also his own
improved version) this package gives a nice overview of what I mean (
http://www.biomedcentral.com/1471-2105/15/S10/P16/figure/F1)


Reply to this email directly or view it on GitHub
#35 (comment).

@mschubert mschubert self-assigned this Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants