Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%or% for length(lhs) > 1 #45

Open
mschubert opened this issue May 11, 2015 · 1 comment
Open

%or% for length(lhs) > 1 #45

mschubert opened this issue May 11, 2015 · 1 comment
Labels

Comments

@mschubert
Copy link
Owner

In base:%or%:

else if (length(a) > 1)
    mapply(cmp, a, b)

Is that what we intend to do?

I know I committed this, but shouldn't it rather be:

else if (length(a) > 1)
    a
@mschubert
Copy link
Owner Author

Actually, I was wrong. I'd argue we do want vector- and matrix based %or%s.

But the implementation right now is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant