diff --git a/src/main/java/org/mskcc/smile/service/impl/CmoLabelGeneratorServiceImpl.java b/src/main/java/org/mskcc/smile/service/impl/CmoLabelGeneratorServiceImpl.java index 670f445..e23ed40 100644 --- a/src/main/java/org/mskcc/smile/service/impl/CmoLabelGeneratorServiceImpl.java +++ b/src/main/java/org/mskcc/smile/service/impl/CmoLabelGeneratorServiceImpl.java @@ -509,6 +509,13 @@ private Integer getNextNucleicAcidIncrement(String nucleicAcidAbbreviation, // to prevent accidentally giving samples the same counter Integer maxIncrement = 0; for (SampleMetadata sample : samples) { + // skip samples with null cmo sample name (possible now that we allow all samples to get in db + // even if they fail validation and/or fail label generation) + if (StringUtils.isBlank(sample.getCmoSampleName())) { + LOG.warn("Skipping patient sample with null CMO sample label: CMO patient ID = " + + sample.getCmoPatientId() + ", sample primary ID = " + sample.getPrimaryId()); + continue; + } // skip cell line samples if (CMO_CELLLINE_ID_REGEX.matcher(sample.getCmoSampleName()).find()) { continue;