Make PathParams type Record<string, string | ReadonlyArray<string>>?

[stefanprobst]

hi, would you consider changing the PathParams type from Record<string, string | string[]> to Record<string, string | ReadonlyArray<string>>?

[kettanaito]

Hey, @stefanprobst. Thank you for the suggestion.

What benefits do you think it'd provide if we switched to ReadonlyArray?

[stefanprobst]

afaiu it is ok to pass Array where ReadonlyArray is expected, but not the other way around. so i have something similar to the following, which does not play nice with the current PathParams from msw:

https://www.typescriptlang.org/play?#code/C4TwDgpgBACghsAFvATnAtgZygXigJQgGMB7FAEwB5NgUBLAOwHMAaKG+5qAH3dsaYBtALoA+AFChIsBMjhos+AIK4CxMlQ4C2Wrr0JxyJBgBsQSlGhDV+zURPGNgEFADM4RaAFkQ8JKgxsCAAPZwZybEJSChtOVj44njVDYzMLK1iBeygAb3EoAqg6cgAuBIFxAF9xcVIGGigweUCynz85BWw8HKLSqAByAEZ+qGrxcmITeWhXAFcGImA6YygiRGIAawAKJs6y9oCsAEoygDcSYtr1om3dwKOaiaIplBn5xeWGVeuN5R3mrD7WSHTDKE5Qc6XNabP53Y7iIA

[kettanaito]

Got it. Thank you for sharing your use case.
I see no harm in annotating path parameters as ReadonlyArray, given that you cannot, in fact, change that array. Would you be interested in opening a pull request with this change?

[stefanprobst]

Would you be interested in opening a pull request with this change?

sure! thanks!