Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALERT]: split out the itemframe mod #23

Open
wsor4035 opened this issue Feb 12, 2022 · 3 comments
Open

[ALERT]: split out the itemframe mod #23

wsor4035 opened this issue Feb 12, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@wsor4035
Copy link
Collaborator

the itemframe mod as it is well used alone outside of the homedecor modpack, will be split out to a separate repo. this issue is to announce the change and solicit opinions if there would be any issues with this not seen yet

@SwissalpS
Copy link
Contributor

It's similar to anvil, a node that is used more than the rest of it's mother mod.
Itemframes and itemstands can work well alone from what I remember.

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Feb 14, 2022
@Niklp09
Copy link
Member

Niklp09 commented Jun 6, 2022

@wsor4035 When do you want to split out the itemframes?

@wsor4035
Copy link
Collaborator Author

wsor4035 commented Jun 7, 2022

@wsor4035 When do you want to split out the itemframes?

good question probably worth comparing against what tenplus1 one is, and if its worth maintaining our own. A thought to address is if it should be submodule back in (so that people not wanting it dont use the submodule at all), but would be there for those wanting backwards compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants