Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection operations not ACID complient #46

Closed
sebastianstucke87 opened this issue Jul 16, 2023 · 2 comments · Fixed by #52
Closed

Collection operations not ACID complient #46

sebastianstucke87 opened this issue Jul 16, 2023 · 2 comments · Fixed by #52

Comments

@sebastianstucke87
Copy link

Hi! First off, thank you for this demo repo! This really did help me get my head around ApiPlattform in a non-vanilla "Symfony architecture" 😀👍

Second, I noticed in POST api/books/anonymize, that each SQL update statement is executed in its own transactions, instead of the entire update being done in a single transaction:

https://github.com/mtarld/apip-ddd/blob/main/src/BookStore/Application/Command/AnonymizeBooksCommandHandler.php#L26
@yceruto yceruto mentioned this issue Dec 27, 2023
Merged
@yceruto
Copy link
Contributor

yceruto commented Dec 27, 2023

Fixed in #52

@sebastianstucke87
Copy link
Author

Fixed in #52

Awesome, thank you! 😃🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementing ACID Transactions yceruto/apip-ddd
2 participants
@yceruto @sebastianstucke87