Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save overwritten when not backed up properly. #425

Open
J65043 opened this issue Dec 3, 2024 · 1 comment
Open

Save overwritten when not backed up properly. #425

J65043 opened this issue Dec 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@J65043
Copy link

J65043 commented Dec 3, 2024

Ludusavi version

v0.27.0

Operating system

Windows

Installation method

Standalone

Description

I have ludusavi on both my steamdeck and Windows computer. I used the wrap with --force command to backup my games for both the steamdeck and windows computer automatically. I forgot to properly close the game when I was shutting down my computer so the backup was never taken. I then used my steamdeck and it restored to cloud automcatically. Since my computer saw a newer save in the cloud it then overwrote my backup locally and in the cloud. we need some proper timestamp checking to detect this.

Logs

No response

@J65043 J65043 added the bug Something isn't working label Dec 3, 2024
@J65043
Copy link
Author

J65043 commented Dec 3, 2024

I propose we use the the size /file modified to check before restoring.
my situation happened because my new save wasn't uploaded or even synced with the backup so cloud sync saw a newer save on the cloud and decided to restore that one. This would also happen if the user is offline when progressing there save and doesn't initiate a save

if the local file size is > than the local backup file size and cloud sync backup . Another check would be to check the modified timestamp on top of that. if the local file modified timestamp is <= local backup file timestamp and local file size > local backup timestamp we should raise a error and let the user decide what to do. we could also implement automatic rules to let it automatically decide what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant