Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard raceable properties with mutex, fixes #19 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard raceable properties with mutex, fixes #19 #20

wants to merge 1 commit into from

Conversation

mrngm
Copy link

@mrngm mrngm commented Oct 29, 2019

No description provided.

mtulio
mtulio requested changes Nov 3, 2019
View reviewed changes
Copy link
Owner

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mrngm , thanks to contribute! 👍

Following the mutex name for TestsSSL and Tests mutex, I suggest to rename the controlInit mutex too, what do you think?

stk/main.go
testsSSLMut sync.Mutex
TestsSSL []*statuscake.Ssl

cmut sync.Mutex
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmut sync.Mutex
cInitMut sync.Mutex

stk/main.go
stk.Tests = tests
stk.cmut.Lock()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stk.cmut.Lock()
stk.cInitMut.Lock()

stk/main.go
if !stk.controlInit {
log.Println(" Initial API discovery returns the Total of Tests:", len(tests))
stk.controlInit = true
}
stk.cmut.Unlock()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stk.cmut.Unlock()
stk.cInitMut.Unlock()

stk/main.go
stk.TestsSSL = ssls
stk.cmut.Lock()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stk.cmut.Lock()
stk.cInitMut.Lock()

stk/main.go
if !stk.controlInit {
log.Println(" Initial API discovery returns the Total of SSL Tests:", len(stk.TestsSSL))
}
stk.cmut.Unlock()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stk.cmut.Unlock()
stk.cInitMut.Unlock()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtulio mtulio mtulio requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrngm @mtulio