Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

Use electron-builder to generate install packages #81

Open
krolow opened this issue Dec 26, 2016 · 3 comments
Open

Use electron-builder to generate install packages #81

krolow opened this issue Dec 26, 2016 · 3 comments

Comments

@krolow
Copy link
Contributor

krolow commented Dec 26, 2016

I was working in PR #78 while doing that I'd like to get a .deb package, so I made some changes in the code to have a electron-builder working together instead of electron-packager.

I'd like to know if it is something that would be valuable for the project, so I can work in some PR?

To achieve that... It would involve to have a linux to build to (win/linux) for that I can setup a docker-compose that would do the build in a mac env...

For mac it adds the dmg installer that can have some icon to install/background and other things... not sure if we do have some art for those things or can I set some default one...

let me know what do you think about...

@muan
Copy link
Owner

muan commented Dec 26, 2016

Thanks @krolow. I'm not very familiar with electron-builder, but from the looks of it I thought it should take care of most things we need, why the following is needed?

To achieve that... It would involve to have a linux to build to (win/linux) for that I can setup a docker-compose that would do the build in a mac env...


To get start with this, since this feature is for .deb, we haven't gotten requests for .dmg, and full Windows support isn't added yet, I think we can punt on the mac/win installer for now (keep using electron-packager for them). Also perhaps could you let me know why an installer is preferred?

@krolow
Copy link
Contributor Author

krolow commented Dec 26, 2016

so it's more a "comfortable" way to install... it would be possible to release the .tar.gz .deb .rpm in the github releases, and we could have a link point to it in README, so people just download the .deb for example and do "dpkg -i mojibar.deb" and we get it installed...

It would allow as well to put it in some apt repository, so in some future we could enable "apt-get install mojibar" from ubuntu/debian directly...

We could leave like it is in #78 but it would involve someone clone the repo, install the deps and run the build... it would take a bit more of time as in linux we don't have a homebrew thing to install directly...

And in linux we do not have Command + Control + Spacebar to get emoji list, so if we do have a release/and/maybe add it in some apt repository, we can get more people using mojibar

@krolow
Copy link
Contributor Author

krolow commented Dec 26, 2016

It also generate the "configuration" necessary to have a gnome app for example, I have used electron-builder here to build a .deb file so that I can install.. this is how it looks like in gnome-shell

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants