Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think there are something unreasonably #13

Open
qwb492859377 opened this issue Sep 24, 2017 · 4 comments
Open

I think there are something unreasonably #13

qwb492859377 opened this issue Sep 24, 2017 · 4 comments

Comments

@qwb492859377
Copy link

this is my fork diff :qwb492859377@87ff22f

I think in addInternal() function, it should compare the timer start time, not duration time.
@muesli
Copy link
Owner

muesli commented Sep 25, 2017

I agree, a timer would be a lot nicer here. Would you mind opening a proper pull request for your proposed changes?

@qwb2333
Copy link

qwb2333 commented Sep 26, 2017

I use my new account which pull requests.And after I will use this account along.

@vaibhavsanap
Copy link

HI @muesli ,
Can I work on this.

@muesli
Copy link
Owner

muesli commented Dec 30, 2020

@vaibhavsanap Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@muesli @vaibhavsanap @qwb492859377 @qwb2333