Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe expirationCheck() which in cachetable.go have a little issues? #15

Open
Hu-Jiang opened this issue Nov 18, 2017 · 1 comment
Open

Comments

@Hu-Jiang
Copy link

Hu-Jiang commented Nov 18, 2017

In expirationCheck function, whether below code should in the function's end(), in other words , i mean in the table.Unlock()'s front ?

if table.cleanupInterval > 0 {
	table.log("Expiration check triggered after", table.cleanupInterval, "for table", table.name)
} else {
	table.log("Expiration check installed for table", table.name)
}

i think, if do this, the log message is more exact and reasonable.

@wade0817wang
Copy link

这段代码应该是表示当前这次的expirationCheck执行距离上次的Interval, 如果放在最后边,cleanupInterval就变成了当前这次距离下次的interval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants