Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useButton] When focusableWhenDisabled the button can still be clicked or pressed #1312

Closed
mj12albert opened this issue Jan 9, 2025 · 0 comments · Fixed by #1313
Closed
Assignees
Labels
component: collapsible This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module! regression A bug, but worse

Comments

@mj12albert
Copy link
Member

mj12albert commented Jan 9, 2025

Regression from #1177

Before we were manually calling external handlers, but using mergeReactProps external handlers are called before our handlers

Affected: collapsible trigger, menu items (regular, checkbox, radio), select items, tabs (TabsTab)

@mj12albert mj12albert added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module! regression A bug, but worse component: collapsible This is the name of the generic UI component, not the React module! labels Jan 9, 2025
@mj12albert mj12albert self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: collapsible This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant