-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Clean up and unify test code #532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
1 task
atomiks
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good (aside from the failing linting to fix)
michaldudak
force-pushed
the
update-test-infra
branch
from
August 9, 2024 11:30
80c7242
to
3f793de
Compare
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Aug 13, 2024
[test] Clean up and unify test code (mui#532) Update docs Update docs wip Tests
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Aug 13, 2024
[test] Clean up and unify test code (mui#532) Update docs Update docs wip Tests Update docs Fix lint Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await
to allact
andrender
callscreateRenderer
(it flushes the microtask queue after rendering)inheritComponent
field from conformance testsflushMicrotasks
in Karma tests) and fixed a few newly failing tests#test-utils
subpath import in package.json to avoid importing from../../../test
.