Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Clean up and unify test code #532

Merged
merged 12 commits into from
Aug 9, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Aug 5, 2024

  • Added await to all act and render calls
  • Using our version of createRenderer (it flushes the microtask queue after rendering)
  • Removed the unused inheritComponent field from conformance tests
  • Updated the test-utils (fixing flushMicrotasks in Karma tests) and fixed a few newly failing tests
  • Introduced the #test-utils subpath import in package.json to avoid importing from ../../../test.
  • Configured ESList with React Testing Library plugin

@mui-bot
Copy link

mui-bot commented Aug 5, 2024

Netlify deploy preview

https://deploy-preview-532--base-ui.netlify.app/

Generated by 🚫 dangerJS against 3f793de

Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good (aside from the failing linting to fix)

@michaldudak michaldudak merged commit 6aad1da into mui:master Aug 9, 2024
18 checks passed
@michaldudak michaldudak deleted the update-test-infra branch August 9, 2024 11:36
atomiks added a commit to atomiks/base-ui that referenced this pull request Aug 13, 2024
[test] Clean up and unify test code (mui#532)

Update docs

Update docs

wip

Tests
atomiks added a commit to atomiks/base-ui that referenced this pull request Aug 13, 2024
[test] Clean up and unify test code (mui#532)

Update docs

Update docs

wip

Tests

Update docs

Fix lint

Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants