[Checkbox] Default Indicator to keepMounted=false
#936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
component: checkbox
Netlify deploy preview |
atomiks
commented
Dec 3, 2024
Comment on lines
77
to
80
| extraProps: { | ||
| hidden, | ||
| ...otherProps, | ||
| }, |
There was a problem hiding this comment.
One consequence of hidden here is that you can't rely on the outer Root checkbox animation, because it looks for animations on the indicator itself: animatedElementRef: indicatorRef. So you need to duplicate styles to keep it mounted; hidden={false} of course can be used
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
michaldudak
approved these changes
Dec 10, 2024
| export const transitionStatusMapping = { | ||
| transitionStatus(value): Record<string, string> | null { | ||
| if (value === 'starting') { | ||
| return { 'data-starting-style': '' }; |
There was a problem hiding this comment.
Nit: you could create the const object beforehand and reuse it in each call.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #896