[docs] Generate external links from mdx #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
force-pushed
the
docs/external-links
branch
from
ca93c6f to
5b6bae7
Compare
Netlify deploy preview |
vladmoroz
reviewed
Dec 12, 2024
docs/src/mdx-components.tsx
Outdated
Comment on lines
22
to
35
| a: (props) => { | ||
| if (props.href.startsWith('http')) { | ||
| return ( | ||
| <Link | ||
| target="_blank" | ||
| rel="noopener" | ||
| {...props} | ||
| className={clsx(props.className, 'inline-flex items-center gap-1')} | ||
| > | ||
| {props.children} | ||
| <ExternalLinkIcon /> | ||
| </Link> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Should we put it in the actual Link component so it can be reused in JSX too? (We'd need to clean the icon from the 404 page then).
vladmoroz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example external links on the about page: https://deploy-preview-1071--base-ui.netlify.app/react/overview/about
Closes #1033