Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Simplify build scripts #131

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

michaldudak
Copy link
Member

Removed the legacy and modern build targets. We'll ship standard ESM (once mui/material-ui#41102 is complete and ready to be ported to Base UI) and CommonJS for Node.

Also removed the custom TS build script, as the issue it works around has been resolved.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Feb 27, 2024
@michaldudak michaldudak requested a review from mnajdova February 27, 2024 21:57
@mnajdova
Copy link
Member

mnajdova commented Mar 1, 2024

Makes sense, should we wait for mui/material-ui#41102 to be merged first?

@michaldudak
Copy link
Member Author

We don't really have to - we're not going to release Base UI packages anytime soon. When mui/material-ui#41102 is merged, we'll have to adapt it anyway so that our "esm" bundle is truly ESM.

@michaldudak michaldudak merged commit e70cc74 into mui:master Mar 15, 2024
16 checks passed
@michaldudak michaldudak deleted the simplify-build branch March 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants