Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Correct Bundlephobia links #419

Merged
merged 1 commit into from
May 29, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented May 28, 2024

The Bundlephobia links in the components docs' headers (the "Bundle size" pill under the header) incorrectly pointed to @mui/base. Once we have just one docs site for Base UI, we'll be able to change the package name globally, in a shared package #422, but for the time being, we have to update each page manually.

https://github.com/mui/material-ui/blob/a55cd51ab4312fd2864dbd59e78a2ed8b5aae3dc/packages/mui-docs/src/ComponentLinkHeader/ComponentLinkHeader.tsx#L34

Preview: https://deploy-preview-419--base-ui.netlify.app/base-ui/react-checkbox

@michaldudak michaldudak added the docs Improvements or additions to the documentation label May 28, 2024
@michaldudak michaldudak requested a review from colmtuite May 28, 2024 13:10
@mui-bot
Copy link

mui-bot commented May 28, 2024

Netlify deploy preview

https://deploy-preview-419--base-ui.netlify.app/

Generated by 🚫 dangerJS against f2e4296

@michaldudak michaldudak merged commit bd5c7a0 into mui:master May 29, 2024
16 checks passed
@michaldudak michaldudak deleted the bundlephobia-links branch May 29, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants