Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Vale errors #492

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 29, 2024

Those errors can be seen by running

vale sync && git ls-files | grep -h ".md$" | xargs vale --filter='.Level=="error"'

It's not in the CI yet because we share the config with the monorepo HEAD, which could mean breaking the CI in Base UI as soon as a PR is merged in the monorepo.

Packages = Google, https://github.com/mui/material-ui/raw/HEAD/docs/mui-vale.zip

We will need to change this.

Those errors can be seen by running

vale sync && git ls-files | grep -h ".md$" | xargs vale --filter='.Level=="error"'

It's not in the CI yet because we share the config with the monorepo HEAD, which
could mean breaking the CI in Base UI as soon as a PR is merged in the monorepo.
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 29, 2024
@oliviertassinari oliviertassinari changed the title [core] Fix Vale errors [docs] Fix Vale errors Jul 29, 2024
@mui-bot
Copy link

mui-bot commented Jul 29, 2024

Netlify deploy preview

https://deploy-preview-492--base-ui.netlify.app/

Generated by 🚫 dangerJS against 1bba089

@oliviertassinari oliviertassinari merged commit 3dd6ed5 into mui:master Jul 29, 2024
18 of 19 checks passed
@oliviertassinari oliviertassinari deleted the vale-sync branch July 29, 2024 14:23
@oliviertassinari oliviertassinari added the regression A bug, but worse label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants