Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SliderRoot] improve disabled prop description #527

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 4, 2024

removed /** from disabled prop description

preview: https://deploy-preview-527--base-ui.netlify.app/base-ui/react-slider/components-api/#slider-root-props

before:
image

after:
image

@mui-bot
Copy link

mui-bot commented Aug 4, 2024

Netlify deploy preview

https://deploy-preview-527--base-ui.netlify.app/

Generated by 🚫 dangerJS against 8cb5a7b

Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sai6855
Copy link
Contributor Author

sai6855 commented Aug 5, 2024

I can't merge PR, please feel free to merge if PR looks good.

@zannager zannager added component: slider This is the name of the generic UI component, not the React module! package: base-ui labels Aug 5, 2024
@michaldudak michaldudak merged commit 2860517 into mui:master Aug 6, 2024
17 of 18 checks passed
@michaldudak
Copy link
Member

There seems to be an issue with Netlify cache (clearing it and rebuilding works well).

@sai6855 sai6855 deleted the disabled-description branch October 22, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants