Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] CheckboxItem component #533

Merged
merged 17 commits into from
Sep 19, 2024
Merged

[Menu] CheckboxItem component #533

merged 17 commits into from
Sep 19, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Aug 5, 2024 •
edited
Loading

Created the MenuCheckboxItem component.

Closes #52

@michaldudak michaldudak added component: menu This is the name of the generic UI component, not the React module! new feature New feature or request labels Aug 5, 2024
@mui-bot
Copy link

mui-bot commented Aug 5, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-533--base-ui.netlify.app/

Generated by 🚫 dangerJS against 88b43f0

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2024
@colmtuite colmtuite requested a review from vladmoroz September 9, 2024 08:54
@michaldudak michaldudak marked this pull request as ready for review September 9, 2024 09:37
@colmtuite
Copy link
Contributor

@michaldudak Same feedback as radio item.

I was surprised that the Menu doesn't close when you select a radio item using Enter. Radix closes the menu whether you select a radio/checkbox item via click, space, or Enter. RA closes on Enter only. Do you think we should keep the Menu open always? Or close when you select a radio item using Enter?

@michaldudak michaldudak merged commit 6127e9d into mui:master Sep 19, 2024
18 checks passed
@michaldudak michaldudak deleted the menu-checkboxitem branch September 19, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite colmtuite approved these changes

@vladmoroz vladmoroz Awaiting requested review from vladmoroz

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu] Create the checkbox menu item
4 participants
@michaldudak @mui-bot @colmtuite @atomiks