[Dialog] Modality changes #977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: alert dialog
Netlify deploy preview |
michaldudak
force-pushed
the
dialog-modality-changes
branch
from
9d83eb5 to
bb66879
Compare
github-actions
bot
added
PR: out-of-date
michaldudak
force-pushed
the
dialog-modality-changes
branch
from
16a17bb to
9a01a54
Compare
atomiks
reviewed
Dec 9, 2024
Comment on lines
8
to
15
| const handleClick = React.useCallback( | ||
| (event: React.MouseEvent) => { | ||
| if (open) { | ||
| setOpen(false, event.nativeEvent, 'click'); | ||
| } | ||
| }, | ||
| [open, setOpen], | ||
| ); |
There was a problem hiding this comment.
Same here - setOpen doesn't change between renders.
atomiks
reviewed
Dec 9, 2024
Comment on lines
39
to
44
| const handleFloatingUIOpenChange = React.useCallback( | ||
| (isOpen: boolean, event: Event | undefined, reason: FloatingUIOpenChangeReason | undefined) => { | ||
| setOpen(isOpen, event, translateOpenChangeReason(reason)); | ||
| }, | ||
| [setOpen], | ||
| ); |
There was a problem hiding this comment.
This depends on setOpen only, which is stable.
There was a problem hiding this comment.
Yeah, but you need to specify the deps needlessly, plus for consistency it's good to wrap event handlers in it since it's used elsewhere
atomiks
reviewed
Dec 11, 2024
Comment on lines
67
to
76
| const handleFloatingUIOpenChange = React.useCallback( | ||
| ( | ||
| nextOpen: boolean, | ||
| event: Event | undefined, | ||
| reason: FloatingUIOpenChangeReason | undefined, | ||
| ) => { | ||
| setOpen(nextOpen, event, translateOpenChangeReason(reason)); | ||
| }, | ||
| [setOpen], | ||
| ); |
There was a problem hiding this comment.
Another here, though this one (and the one above) actually doesn't need to be wrapped, since it's done internally already
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reasonparameter to Dialog'sonOpenChangemodalprop valuepart of #623