[LoadingButton] does not inherit custom variant override types

[awdyson]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

LoadingButton properly renders the styles set in MuiButton.styleOverrides, however the console throws an Invalid Prop Type Value error. I'd guess that this is also a

Expected behavior 🤔

I don't think this used to throw an error? Regardless, this should be an acceptable usage no? Or maybe there needs to be a LoadingButtonPropsVariantOverrides interface?

Steps to reproduce 🕹

1. Create a ButtonPropsVariantOverrides interface

declare module '@mui/material/Button' {
  interface ButtonPropsVariantOverrides {
    foobar: true;
  }
}

2. Add some custom styling for these new variants
3. Try using said variant

<LoadingButton variant="foobar">Some Button</LoadingButton>

4. Check the console for error

Context 🔦

This is an issue when needing more than the supplied variants -- at least for components that inherit from an override-able source.

Your environment 🌎

`npx @mui/envinfo`

  System:
    OS: macOS 11.6.2
  Binaries:
    Node: 14.16.1 - ~/.local/share/nvm/v14.16.1/bin/node
    Yarn: 3.1.1 - ~/.local/share/nvm/v14.16.1/bin/yarn
    npm: 7.11.2 - ~/.local/share/nvm/v14.16.1/bin/npm
  Browsers:
    Chrome: 97.0.4692.71

[mnajdova]

Is the issue related to the typings or the propTypes? I think we only need to update the propTypes and add test for it:

index 0a7616f608..48404ab2b5 100644
--- a/packages/mui-lab/src/LoadingButton/LoadingButton.js
+++ b/packages/mui-lab/src/LoadingButton/LoadingButton.js
@@ -266,7 +266,10 @@ LoadingButton.propTypes /* remove-proptypes */ = {
    * The variant to use.
    * @default 'text'
    */
-  variant: PropTypes.oneOf(['contained', 'outlined', 'text']),
+   variant: PropTypes /* @typescript-to-proptypes-ignore */.oneOfType([
+    PropTypes.oneOf(['contained', 'outlined', 'text']),
+    PropTypes.string,
+  ]),
 };

 export default LoadingButton;

Feel free to pick it up if you want.

[niishaaant]

Hi,
I just left a PR #30880 fixing the issue thanks to @mnajdova . This would be my first contribution so leaving a comment telling me if I did everything right or where I messed up would really help.

[CarlosAmaral]

This doesn't seem to work anymore.