-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Unified Modern Standard Arabic localization #31847
Comments
We cannot just remove the arabic localization that exists, as it would be a breaking change. What you say makes sense, but I am not an expert in arabic languages for sure :) Let's wait to see if we will see more upvotes to this. Would that work? In the mean time, you can add in your theme overrides the locale as you see fit. |
@mnajdova but you can. as a temporary measure, add Modern Standard Arabic to the list of locales, then remove the old ones, in the next major release. |
This comment was marked as off-topic.
This comment was marked as off-topic.
I am leaving this at this moment to you, to do in your style overrides, and we can decide in v6 if we are going to make the change, based on upvotes on this issue. |
Could you please explain more? what do you want me to do excatly? |
If we don't decide to drop the various As for dropping the variants, how do similar projects handle the Arabic language(s) ? |
Personally as i noticed in some apps by Google and Microsoft have many |
The localization are simply filling the theme with default props for the components (for the content/aria generation labels etc). If there is no default prop for the particular string/or there are no localization, yes the will be filled with English, as that is what we have by default in the components). |
As I understand it from https://en.wikipedia.org/wiki/Varieties_of_Arabic and https://www.youtube.com/watch?v=SDxGAH83cuo there are differences between these locales. We could add a Modern Standard Arabic locale, maybe as just |
@oliviertassinari |
@oliviertassinari |
Based on mui/mui-x#15693 (comment) I would agree with the proposal. |
To continue the discussion that is happening in mui/mui-x#15693. Overall, I believe that our naming strategy is:
@DiegoAndai I think we should push more on this, the default should be to replicate https://mui.com/material-ui/guides/localization/#:~:text=Egypt&text=Saudi%20Arabia&text=Sudan, unless there is a direction change. Ownership of this will actually move to be a Base UI concern. If there is a direction change, all projects should adapt as fast as they can. I don't think we should wait upstream to propagate downstream.
@LukasTy I disagree on this one en-US and en-GB are not the same locales. Spelling, vocabulary, etc. is different. So I think this is correct. If people want to only support "en" they can pick one of the two.
This seems to make sense, the same basque is spoken in France and Spain, so same language but different regions. If we add a region, we need to duplicate it, it's not pragmatic.
This seems to be a mistake, I saw no justification to change, added to #32288 (comment). It's technically not wrong, but it seems to be inconsistent with the above naming strategy.
@LukasTy I think it depends on how we look at this:
As I understand this https://www.reddit.com/r/learn_arabic/comments/193tdsa/comment/khbpjtw/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button, both are used in practice. I guess the ideal is that we can kill each locale and only have Standard Arabic. I don't know if it works in practice though. |
Fair point. I had simple translations in mind, but generally, in most cases
I would disagree that this is a mistake. 🤷
Yes, I checked that there are differences in country-specific translations. |
To give the bigger picture:
TL;DR: We should have one Arabic localization language. Now, some operating systems provide languages per country (ex. Android), but the differences are in numeric, date and time, currencies and locale-based settings. Since they don't want to confuse end-users by providing two settings, they had to combine them into one. We could look into cases where MUI should be different based on locale settings (ex. number formats), and see how that can be handled. This is a rather hard subject as you could use, in the operating system, the English language as a translation, but with an Arabic locale. Something like "Created on Jun 24th, 2024" will be "Created on ٢٤ يناير ٢٠٢٤" (notice how it can be weird to read). |
@LukasTy Technically What would be the value of such a policy? As I understand locales, they are meant to set conventions on how to communicate: human <> human, and machine <> human. Because humans barely move, and machines often have a physical fixed location, those locales are very often tied to specific GPS coordinates, so to a region. By defaulting to be specific, we avoid the cases where we name a locale and then realize there is another frequently used one that shares the same prefix, and so is confusing.
This makes sense to me, a playbook could look like this:
@SafaAlfulaij Then this could be a problem, today, our locale includes date and number formatting. What's the difference? We are exploring solutions at #24495. It would make sense to decouple number format locale, to date format locale, to text format locale. As you illustrated in the case below ⬇️
I have something similar on my phone (Android). I have set On my laptop (macOS), I have the same setup, but this time, it feels right: locale: |
The pickers don't have any |
Summary 💡
You are supporting Arabic language based on countries... but the problem is Arabic language has a standard that all can understand. therefore, instead of having to do multiple locales for each Arabic speaking country, just support the Modern Standard Arabic. I don't know if there is a code for it. I mean it is just 'ar'. and since you only willing to accept only up 100 locales I think localizing to Arabic by country is a waste. and eventually Arab do not write in dialect. all books and websites used the same language "Modern Standard Arabic". if this is possible, I can do a PR.
Examples 🌈
https://mui.com/material-ui/guides/localization/
Instead of having 'ar-SD', 'ar-SA', 'ar-EG', it should only be 'ar'
Motivation 🔦
It does not make any since to have so many locales for Arabic, and all use Standard Arabic for writing things.
The text was updated successfully, but these errors were encountered: