[material-ui][Select] Deprecate composed classes #42950
Conversation
Netlify deploy previewBundle size report |
sai6855
added
component: select
| const { container } = render(<Select value="" />); | ||
| expect(container.querySelector('.MuiSelect-iconOutlined')).not.to.equal(null); | ||
| expect( | ||
| container.querySelector('.MuiSelect-outlined ~ .MuiSelect-icon'), |
There was a problem hiding this comment.
To make sure new selector is actually working
|
ping @DiegoAndai |
github-actions
bot
added
the
PR: out-of-date
There was a problem hiding this comment.
@sai6855 I'm so sorry for the delay. May I ask you to update this PR so we can move forward with the changes?
Small comments:
| Use the [codemod](https://github.com/mui/material-ui/tree/HEAD/packages/mui-codemod#select-classes) below to migrate the code as described in the following sections: | ||
|
|
||
| ```bash | ||
| npx @mui/codemod@next deprecations/select-classes <path> |
There was a problem hiding this comment.
| npx @mui/codemod@next deprecations/select-classes <path> | |
| npx @mui/codemod@latest deprecations/select-classes <path> |
packages/mui-codemod/README.md
Outdated
| ``` | ||
|
|
||
| ```bash | ||
| npx @mui/codemod@next deprecations/select-classes <path> |
There was a problem hiding this comment.
| npx @mui/codemod@next deprecations/select-classes <path> | |
| npx @mui/codemod@latest deprecations/select-classes <path> |
github-actions
bot
removed
the
PR: out-of-date
There was a problem hiding this comment.
Thanks @sai6855
For a follow up PR:
Would you be interested in abstracting the codemod logic for the composed classes codemods, similar to what we have for the slots pattern: https://github.com/mui/material-ui/blob/master/packages/mui-codemod/src/deprecations/utils/replaceComponentsWithSlots.js
This would make future PRs easier to review and the code easier to maintain. Let me know.
👍 opened new PR here #44925 |
Let me take a stab at this |
part of #41282
Not sure about argos failure, don't think it's related to this PR