-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][StepContent] Add slots and slotProps #44742
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-44742--material-ui.netlify.app/ StepContent: parsed: +2.35% , gzip: +2.06% Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sai6855 I replied in #42157 (comment), but that's a special case. For TransitionComponent
, lets deprecate as we did with the others: https://mui.com/material-ui/migration/migrating-from-deprecated-apis/#transitioncomponent
Besides that, the PR is good 👍🏼 but please let's deprecate in the same PR.
In cases you shown above, |
@sai6855 thanks for checking. I still think we should go forward with the deprecation, as:
Again, thanks for checking first. I think it won't be a problem, but if users have issues, we can remove/change the deprecation in the future. |
Part of #41281
This PR just adds
slots
andslotProps
and doesn't deprecateTransitionComponent
yet. See this discussion for why it's not deprecated yet #42167 (comment)Once above discussion is resolved, I'd like to deprecate
TransitionComponent
in seperate PR