[material-ui][Pagination] Use correct aria-current value
#44753
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Laurence <[email protected]>
jacklaurencegaray
changed the title
mj12albert
added
accessibility
mj12albert
changed the title
aria-current value
Sriram-Prasanth
approved these changes
Dec 13, 2024
|
@jacklaurencegaray Thanks for working on this ~ you'd need to update the tests here to pass the CI checks! |
Done. |
Netlify deploy previewhttps://deploy-preview-44753--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
|
Just pinging @aarongarciah to see if you would see this as a breaking change, it changes the SR announcement |
aarongarciah
changed the title
aria-current valuearia-current value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pagination mechanism in the docs reads the current page in the screen reader as "current item". By using
aria-current="page"instead ofaria-current="true", the screen reader reads it more clearly as "current page".This is correct property described in the pagination w3c spec.