Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Link] Fix error for using custom palette with underline #44927

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

siriwatknp
Copy link
Member

closes #44900

@siriwatknp siriwatknp added bug 🐛 Something doesn't work component: link This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 3, 2025
@siriwatknp siriwatknp added the customization: theme Centered around the theming features label Jan 3, 2025
@siriwatknp siriwatknp force-pushed the fix/link-custom-palette branch from c2c1f95 to aac2ef8 Compare January 3, 2025 07:33
@mui-bot
Copy link

mui-bot commented Jan 3, 2025

Netlify deploy preview

https://deploy-preview-44927--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against aac2ef8

@DiegoAndai
Copy link
Member

@siriwatknp Even though it's a simple change, it would be better to add a description explaining the changes and their rationale. Without it, it is much harder to review as the reviewer needs to figure out what the change is about before being able to review.

@siriwatknp
Copy link
Member Author

@siriwatknp Even though it's a simple change, it would be better to add a description explaining the changes and their rationale. Without it, it is much harder to review as the reviewer needs to figure out what the change is about before being able to review.

Thanks for the feedback. I thought that the description above the code was enough, will add more details to the PR next time.

@siriwatknp siriwatknp merged commit 34b6ca4 into mui:master Jan 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: link This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Link] TypeError: color.charAt is not a function error message
3 participants