-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Fix type resolution for @mui/types #45513
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-45513--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this fix @Janpot!
- Just to check that I understand this correctly: This seemed to start on
7.0.0-beta.3
but actually, it started on@mui/types
7.2.23
as we used the new package layout but the package wasn't ready for it, right? - What should we do with versioning? Should this bump the major on
@mui/types
? It would become8.0.0
. I don't know the reason this package is versioned differently from the others.
@DiegoAndai The package was built differently than the others and it suddenly got an exports field without having the correct files. For some reason it's not bumped with the major version, I didn't realize, but really, this should follow the major version. I believe we could do the following:
|
On a project that depends on
@mui/material
, when runningtsc
with the--traceResolution
flag I can see that formoduleResolution: 'node'
it printsand for
moduleResolution: 'bundler'
it printsLooking at the
@mui/types
package, it's indeed not a proper dual mode package, I'm aligning it with our other packages to get correctly resolving types.Confirmed that this fixes #45510