-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Column Visibility - Reset Button Confuses Users #16072
Comments
@bbosreferrals thanks for the suggestion. @bbosreferrals to just change the default label, you can use Localization feature and override To change the button's behavior and/or to add more buttons, you will have to pass a custom component to the It is not perfect because you have to override the whole panel, but it will solve your problem. To make this experience better we are actually working on a new set of composable components. This will make it easier to make the customizations like yours. You can follow the linked PR to get the updates. Hope that this helps. |
I think "Undo" would be clearer. It is confusing - it would make more sense to reset to the initial columns state IMO. Is there a reason we only reset the changes that were made whilst the columns panel is open? @mui/xgrid |
I agree it's confusing and the Reset button should behave the same regardless of whether the panel was closed before reset 👍🏻 |
I think so. From an end user perspective, the first controlled model is the initial state of column visibility. |
I have tracked down the requirement for the button to #5700
For me it looks like that this is aligned with the motivation from this issue, so we should update the button action to actually reset. Now, since we already have the logic for "Undo", should we have both actions in the panel or that might be too much? |
No, I think the new Reset behavior should replace the old one, otherwise it would be confusing. |
@bbosreferrals as a temporary workaround you can use my earlier suggestion. |
Summary
The reset button in the column selection pane confuses all users we've tested the function with. Everyone expects it to reset the columns back to the default ones. But it becomes disabled after you select columns and people are confused why it only works when you're actively selecting columns.
Here's short video showing the issue: https://vimeo.com/1043746747/2e32b38b79?share=copy
Does MUI have any advice or future functionality to address this?
Examples
https://mui.com/x/react-data-grid/column-visibility/#column-visibility-panel
Motivation
Allow our customers to easily revert back to our default columns.
Search keywords: Column Visibility, column Reset Button
The text was updated successfully, but these errors were encountered: