[test] Fix adapters code coverage

[alexfauquette]

The #13608 PR revealed the codecov.yml was not valid. So the 100% requirement was not applied.

This PR fix the config file by moving ignore parameter, and add missing tests

There are still some remaining untested lines

The remaining lines

✅ Luxon

I don't see in which case the localised week day could not be defined

Warning

This is probably untestable.
The localeWeekNumber is defined only with latest luxon release, where the support for it was added.
Added an istanbul ignore next to omit it from coverage.

mui-x/packages/x-date-pickers/src/AdapterLuxon/AdapterLuxon.ts

Line 488 in 9ba6b5f

return value.localWeekNumber ?? value.weekNumber;

✅ Dayjs

Technically we could add a test "it should not display the error message in production"

Tip

Not sure it is worth it.
Added an istanbul ignore next to omit it from coverage.

mui-x/packages/x-date-pickers/src/AdapterDayjs/AdapterDayjs.ts

Line 251 in b795564

if (process.env.NODE_ENV !== 'production') {

✅ DateFns (v2,v3, v2 jalaali, v3 jalaali)

✅ Major version assertions

Tip

Added an istanbul ignore next to omit it from coverage.

mui-x/packages/x-date-pickers/src/AdapterDateFnsV3/AdapterDateFnsV3.ts

Lines 90 to 97 in b795564

	if (typeof addDays !== 'function') {
	throw new Error(
	[
	`MUI: The \`date-fns\` package v2.x is not compatible with this adapter.`,
	'Please, install v3.x of the package or use the `AdapterDateFns` instead.',
	].join('\n'),
	);
	}

mui-x/packages/x-date-pickers/src/AdapterDateFnsV3/AdapterDateFnsV3.ts

Lines 98 to 102 in b795564

	if (!longFormatters) {
	throw new Error(
	'MUI: The minimum supported `date-fns` package version compatible with this adapter is `3.2.x`.',
	);
	}

mui-x/packages/x-date-pickers/src/AdapterDateFnsJalaliV3/AdapterDateFnsJalaliV3.ts

Line 163 in b795564

return this.locale?.code || 'fa-IR';

✅ Locale code fallback

Warning

I have removed the fallback, because locale and it's code is always defined: cd2412f.
As listed below: if an invalid locale is passed without a code: that's a problem that I'm not sure we should be safeguarding against. 🤷

With the adapter having the following defaultize, the only way I found to have no locale.code is to pass an invalid locale string. But that make no sens because other methods will faill

locale: locale ?? defaultLocale,

Proposal

We could set the config file with threshold: 0% to just be sure we do not deteriorate this

[mui-bot]

Deploy preview: https://deploy-preview-13969--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 181ff21

[LukasTy]

@alexfauquette Thank you for taking care of it. 🙏
I'll have a look at improving things here. 👍

[flaviendelangle]

This is probably untestable.

Yeah it is 😬
You can add:

/* istanbul ignore next */

LukasTy proposal is to reduce the threshold slightly (to 99.5%) to leave some slack for those edge cases, that we do not want to hack some extra behavior into properly increasing the coverage.

I would personally use istanbul ignore next instead of decreasing the threshold. At least we decide which lines are edge cases.

[LukasTy]

I would personally use istanbul ignore next instead of decreasing the threshold. At least we decide which lines are edge cases.

Thanks for reminding about this. 👍
Would you also revert the changes I've done with the addDays and longFormatters moving? 🤔

[LukasTy]

I have reverted the previous changes and added this check to avoid bundling these warning in production.
Do you think it is worth it?

[alexfauquette]

Good for me

[flaviendelangle]

For the warnOnce, it's definitely worth it

[LukasTy]

Well, given that I've done part of the work, I'm leaving the approval step for @flaviendelangle. 🙈

[alexfauquette]

I can't approve since I'm the author, but this PR looks good to me 👍

For the remaining line not tested, probably skipping it is the good way

https://app.codecov.io/gh/mui/mui-x/pull/13969/blob/packages/x-date-pickers/src/AdapterDayjs/AdapterDayjs.ts#L281