-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Switcher on SignIn Page #4328
Comments
I have separated the |
I feel like I've never seen this in a sign in page. perhaps we should benchmark existing solutions? |
I checked the UX of the following three websites and none of them have theme switcher on the sign-in page. It's part of the user's settings. Notion sign-in page: Always shows light theme (even when my browser and Notion has the Dark theme enabled) |
I'm also interested in this use case. If you won't implement it, can you at least advise what would be the recommended approach? ThemeSwitcher currently stores theme settings in context, so it needs AppProvider as a parent, right? Can I skip dashboard layout? I had som trouble getting this to work. My routes are configured that the AppProvider only renders for authenticated content. Public content (like login page) do not render it. If I add AppProvider on login page and the authenticated content shows a different instance of AppProvider, will this work? Will it use the same storage for theme? |
Pedro is best placed to answer this but he's out this week, I'll tag him here @apedroferreira so he can look at this next week and come back with a reply on what the most recommended way to do this could be |
Hi, yes the new Our recommended approach is that a single instance of You can also take a look at the custom theme switcher example here (https://mui.com/toolpad/core/react-dashboard-layout/#examples) if you want another alternative and your theme uses CSS variables like the default theme. |
Summary
Incorporating a theme switcher to toggle between dark and light modes on the SignIn/SignUp pages might be beneficial.
Examples
No response
Motivation
Enhancing UI/UX by providing users with the option to select their preferred mode from these pages.
Search keywords: signinpage
The text was updated successfully, but these errors were encountered: