Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PageContainer] Replace PageContainer component with just PageHeader #4525

Open
apedroferreira opened this issue Dec 9, 2024 · 0 comments
Open

[PageContainer] Replace PageContainer component with just PageHeader #4525

apedroferreira opened this issue Dec 9, 2024 · 0 comments
Labels
component: PageContainer scope: toolpad-core Abbreviated to "core"

Comments

@apedroferreira
Copy link
Member

apedroferreira commented Dec 9, 2024 •
edited by github-actions bot
Loading

Summary

Right now, PageContainer and PageHeader are separate components.
As discussed in #4480 and #4324, perhaps there should only be a PageHeader component that could simply be wrapped in a standard Material UI Container.

Equivalent usage to the current PageContainer, including taking up the full available size inside a layout and appropriate spacing would have to be documented for the PageHeader component.

Examples

No response

Motivation

Reaching a simple, easy to understand and more customizable API.

Search keywords: page container header
@apedroferreira apedroferreira changed the title [PageContainer] Replace PageContainer component with just a PageHeader [PageContainer] Replace PageContainer component with just PageHeader Dec 9, 2024
@apedroferreira apedroferreira mentioned this issue Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: PageContainer scope: toolpad-core Abbreviated to "core"
Projects
MUI Toolpad public roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apedroferreira