Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does it work with the puppeteer v22.12.0 ? #133

Open
dvdvdmt opened this issue Jun 23, 2024 · 1 comment · May be fixed by #134
Open

Does it work with the puppeteer v22.12.0 ? #133

dvdvdmt opened this issue Jun 23, 2024 · 1 comment · May be fixed by #134

Comments

@dvdvdmt
Copy link

dvdvdmt commented Jun 23, 2024

Hi, I'm facing the issue during the Github action execution in my CI.
I've upgraded the version of the puppeteer recently from ^20.1.2 to ^22.12.0 and now the job started to fail with these errors:

Error: Browser was not found at the configured executablePath (google-chrome-stable)

Observations:

  • Version 22.12.0
    • Works fine locally outside container on MacOS
    • ❌ Fails in CI
  • Version 20.9.0
    • Works fine locally outside container on MacOS
    • Works in CI

Could you take a look if this handy Action (❤️) needs an upgrade to be compatible with the new shiny version of Puppeteer?
@mymindstorm mymindstorm linked a pull request Jun 26, 2024 that will close this issue
Open
@mymindstorm
Copy link

I think I've got the issue figured out. Made #134 to remediate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PUPPETEER_EXEC_PATH for puppeteer 22.* and above mymindstorm/puppeteer-headful
2 participants
@dvdvdmt @mymindstorm