Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #49

Closed
ruihildt opened this issue Dec 1, 2021 · 6 comments · Fixed by #94
Closed

Add tests #49

ruihildt opened this issue Dec 1, 2021 · 6 comments · Fixed by #94
Assignees

Comments

@ruihildt
Copy link
Member

ruihildt commented Dec 1, 2021

Add tests to:

  • Carousel empty/not empty
  • Location loading/error/loaded
  • recommendations card ignored/enabled
@hankolsen
Copy link
Collaborator

Hmmm, the magicly imported icons turns out to be an issue :(
And, apparently vite and jest are not best pals at all unplugin/unplugin-icons#108

@hankolsen
Copy link
Collaborator

vitejs/vite#1955

@ruihildt
Copy link
Member Author

Hmmm, the magicly imported icons turns out to be an issue :( And, apparently vite and jest are not best pals at all antfu/unplugin-icons#108
That's fun! :D

We are our options? Use other icons? I think Naive has some sort of recommended icons, would that work?

@hankolsen
Copy link
Collaborator

Other icons would probably solve this particular issue, however as discussed in vitejs/vite#1955 there are other issues with vite/jest.
I'd say postpone the test requirement for now.

@hankolsen
Copy link
Collaborator

Vitest looks interesting however they explicitly tell you not to use it.... image

@ruihildt
Copy link
Member Author

Other icons would probably solve this particular issue, however as discussed in vitejs/vite#1955 there are other issues with vite/jest. I'd say postpone the test requirement for now.

👍🏼

@hankolsen hankolsen linked a pull request Jan 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants