From 0dfccf7cae9fd6107633b82bf74efffb04d5189e Mon Sep 17 00:00:00 2001 From: Bug Magnet Date: Mon, 11 Nov 2024 15:23:09 +0100 Subject: [PATCH] Disable testAppStillFunctioningWhenAPIDown because of ATS in iOS 18 --- ios/MullvadVPNUITests/ConnectivityTests.swift | 6 ++++++ mullvad-ios/src/encrypted_dns_proxy.rs | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ios/MullvadVPNUITests/ConnectivityTests.swift b/ios/MullvadVPNUITests/ConnectivityTests.swift index a1a49ffd8e23..6b66a2d5142c 100644 --- a/ios/MullvadVPNUITests/ConnectivityTests.swift +++ b/ios/MullvadVPNUITests/ConnectivityTests.swift @@ -143,6 +143,12 @@ class ConnectivityTests: LoggedOutUITestCase { // swiftlint:disable function_body_length /// Test that the app is functioning when API is down. To simulate API being down we create a dummy access method func testAppStillFunctioningWhenAPIDown() throws { + let skipReason = """ + This test is currently skipped due to a bug in iOS 18 where ATS shuts down the + connection to the API in the blocked state, despite being explicitly disabled, + and after the checks in SSLPinningURLSessionDelegate return no error. + """ + try XCTSkipIf(true, skipReason) let hasTimeAccountNumber = getAccountWithTime() addTeardownBlock { diff --git a/mullvad-ios/src/encrypted_dns_proxy.rs b/mullvad-ios/src/encrypted_dns_proxy.rs index 3c89faf89502..2aa83d833dc0 100644 --- a/mullvad-ios/src/encrypted_dns_proxy.rs +++ b/mullvad-ios/src/encrypted_dns_proxy.rs @@ -95,8 +95,8 @@ impl EncryptedDnsProxyState { pub unsafe extern "C" fn encrypted_dns_proxy_init( domain_name: *const c_char, ) -> *mut EncryptedDnsProxyState { - // SAFETY: domain_name points to a valid region of memory and contains a nul terminator. let domain = { + // SAFETY: domain_name points to a valid region of memory and contains a nul terminator. let c_str = unsafe { CStr::from_ptr(domain_name) }; String::from_utf8_lossy(c_str.to_bytes()) };