diff --git a/mullvad-nsis/Cargo.toml b/mullvad-nsis/Cargo.toml index 17240ca22d51..7bf430b20807 100644 --- a/mullvad-nsis/Cargo.toml +++ b/mullvad-nsis/Cargo.toml @@ -15,4 +15,4 @@ crate_type = ["staticlib"] mullvad-paths = { path = "../mullvad-paths" } [target.i686-pc-windows-msvc.build-dependencies] -cbindgen = { version = "0.24.3", default-features = false } \ No newline at end of file +cbindgen = { version = "0.24.3", default-features = false } diff --git a/mullvad-paths/src/windows.rs b/mullvad-paths/src/windows.rs index 9fb778b37739..e41f9faec9f7 100644 --- a/mullvad-paths/src/windows.rs +++ b/mullvad-paths/src/windows.rs @@ -218,7 +218,7 @@ fn set_security_permissions(path: &Path) -> Result<()> { &mut new_dacl, ) }; - if ERROR_SUCCESS != result { + if result != ERROR_SUCCESS { return Err(Error::SetDirPermissionFailed( String::from("SetEntriesInAclW failed"), io::Error::from_raw_os_error( @@ -242,7 +242,7 @@ fn set_security_permissions(path: &Path) -> Result<()> { unsafe { LocalFree(new_dacl as isize) }; - if ERROR_SUCCESS != result { + if result != ERROR_SUCCESS { Err(Error::SetDirPermissionFailed( String::from("SetNamedSecurityInfoW failed"), io::Error::from_raw_os_error( diff --git a/windows/nsis-plugins/src/log/log.cpp b/windows/nsis-plugins/src/log/log.cpp index fe7137cba5fb..c0bbab0c1acd 100644 --- a/windows/nsis-plugins/src/log/log.cpp +++ b/windows/nsis-plugins/src/log/log.cpp @@ -294,12 +294,12 @@ void __declspec(dllexport) NSISCALL SetLogTarget FOLDERID_ProgramData)); logpath.append(L"Mullvad VPN"); - const wchar_t* w_path = logpath.wstring().c_str(); + const wchar_t* w_path = logpath.wstring().c_str(); - if (Status::Ok != create_privileged_directory(reinterpret_cast(w_path))) - { - THROW_ERROR("Failed to create privileged directory"); - } + if (Status::Ok != create_privileged_directory(reinterpret_cast(w_path))) + { + THROW_ERROR("Failed to create log directory"); + } logpath.append(logfile); diff --git a/windows/nsis-plugins/src/log/log.vcxproj b/windows/nsis-plugins/src/log/log.vcxproj index d4b63f307a3f..7509919f195f 100644 --- a/windows/nsis-plugins/src/log/log.vcxproj +++ b/windows/nsis-plugins/src/log/log.vcxproj @@ -74,6 +74,10 @@ libc.lib log.def + + cargo build --target i686-pc-windows-msvc --release -p mullvad-nsis + Build mullvad-nsis library + @@ -100,6 +104,10 @@ libc.lib log.def + + cargo build --target i686-pc-windows-msvc --release -p mullvad-nsis + Build mullvad-nsis library + diff --git a/windows/nsis-plugins/src/tray/tray.vcxproj b/windows/nsis-plugins/src/tray/tray.vcxproj index 108bf52b7860..15561ff6bfd0 100644 --- a/windows/nsis-plugins/src/tray/tray.vcxproj +++ b/windows/nsis-plugins/src/tray/tray.vcxproj @@ -69,8 +69,8 @@ Windows true false - $(ProjectDir)../../../../target/i686-pc-windows-msvc/release;$(ProjectDir)../../../../dist-assets/binaries/x86_64-pc-windows-msvc/nsis/;$(SolutionDir)bin\$(Platform)-$(Configuration)\ - mullvad_nsis.lib;psapi.lib;log.lib;libcommon.lib;pluginapi-x86-unicode.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies) + $(ProjectDir)../../../../dist-assets/binaries/x86_64-pc-windows-msvc/nsis/;$(SolutionDir)bin\$(Platform)-$(Configuration)\ + log.lib;libcommon.lib;pluginapi-x86-unicode.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies) libc.lib tray.def @@ -95,8 +95,8 @@ true true false - $(ProjectDir)../../../../target/i686-pc-windows-msvc/release;$(ProjectDir)../../../../dist-assets/binaries/x86_64-pc-windows-msvc/nsis/;$(SolutionDir)bin\$(Platform)-$(Configuration)\ - mullvad_nsis.lib;psapi.lib;log.lib;libcommon.lib;pluginapi-x86-unicode.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies) + $(ProjectDir)../../../../dist-assets/binaries/x86_64-pc-windows-msvc/nsis/;$(SolutionDir)bin\$(Platform)-$(Configuration)\ + log.lib;libcommon.lib;pluginapi-x86-unicode.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies) libc.lib tray.def