From 51eca94a522f988dbbe07d72bbfeb056d6d9690e Mon Sep 17 00:00:00 2001 From: Markus Pettersson Date: Mon, 4 Nov 2024 07:53:01 +0100 Subject: [PATCH] Mitigate `test_quantum_resistant_multihop_shadowsocks_tunnel` flakiness Limit relay selection in `test_quantum_resistant_multihop_shadowsocks_tunnel` to reduce flakiness. Hopefully this should be able to (at least partially) mitigate timeout-related issues. --- test/test-manager/src/tests/tunnel.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/test-manager/src/tests/tunnel.rs b/test/test-manager/src/tests/tunnel.rs index 6fb57adc1498..9297b029c37c 100644 --- a/test/test-manager/src/tests/tunnel.rs +++ b/test/test-manager/src/tests/tunnel.rs @@ -568,6 +568,13 @@ pub async fn test_quantum_resistant_multihop_shadowsocks_tunnel( .wireguard() .multihop() .shadowsocks() + // NOTE: We have experienced flakiness due to timeout issues if distant relays are selected. + // This is an attempt to try to reduce this flakiness, but it relies on the following + // assumptions: + // 1. The client running this test is located in Sweden + // 2. There are at least two wireguard relays in Sweden + .entry(relay_constraints::GeographicLocationConstraint::country("se")) + .location(relay_constraints::GeographicLocationConstraint::country("se")) .build(); apply_settings_from_relay_query(&mut mullvad_client, query).await?;