From 7704e46b1c8febc7410feb498c00e9818e198043 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Em=C4=ABls?= Date: Thu, 9 Nov 2023 14:36:19 +0100 Subject: [PATCH] Remove offending test --- ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift b/ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift index e17f48c3302c..34a6fe34787d 100644 --- a/ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift +++ b/ios/PacketTunnelCoreTests/PacketTunnelActorTests.swift @@ -302,7 +302,12 @@ final class PacketTunnelActorTests: XCTestCase { await fulfillment(of: [disconnectedStateExpectation, didStopObserverExpectation], timeout: 1) } - func testSetErrorStateGetsCancelledWhenStopping() async throws { + // FIXME: Reconsider if this test should exist. As it stands currently, it + // relies the packet tunnel process processing app message calls and a + // `stopTunnel()` call in a particular, deterministic order, which makes it + // unreliable. In reality, we cannot guarantee the order between those + // calls, and it fails almost reliably on low core count VMs. + func setErrorStateGetsCancelledWhenStopping() async throws { let actor = PacketTunnelActor.mock() let connectingStateExpectation = expectation(description: "Connecting state") let disconnectedStateExpectation = expectation(description: "Disconnected state")