Merge branch 'fix-clippy-lints'

Author: MarkusPettersson98

Cargo.lock

@@ -62,7 +62,7 @@ simple-signal = "1.1"
 talpid-dbus = { path = "../talpid-dbus" }
 
 [target.'cfg(target_os="macos")'.dependencies]
-objc = { version = "0.2.7", features = ["exception", "verify_message"] }
+objc2 = { version = "0.5.2", features = ["exception"] }
 
 [target.'cfg(windows)'.dependencies]
 ctrlc = "3.0"

mullvad-daemon/Cargo.toml

@@ -5,10 +5,11 @@
 //! must be checked so that the user can be directed to approve the launch
 //! daemon in the system settings.
 
-use objc::{class, msg_send, sel, sel_impl};
+use libc::c_longlong;
+use objc2::{class, msg_send, runtime::AnyObject, Encode, Encoding, RefEncode};
 use std::ffi::CStr;
 
-type Id = *mut objc::runtime::Object;
+type Id = *mut AnyObject;
 
 // Framework that contains `SMAppService`.
 #[link(name = "ServiceManagement", kind = "framework")]
@@ -18,18 +19,23 @@ extern "C" {}
 #[repr(C)]
 #[derive(Debug)]
 struct NSOperatingSystemVersion {
-    major_version: libc::c_longlong,
-    minor_version: libc::c_longlong,
-    patch_version: libc::c_longlong,
+    major_version: c_longlong,
+    minor_version: c_longlong,
+    patch_version: c_longlong,
 }
 
-/// Implement Objective-C type encoding for the struct. Allows the `objc` crate
+/// Implement Objective-C type encoding for the struct. Allows the `objc2` crate
 /// to perform function signature matching before performing calls into the Objective-C
-/// runtime. This is needed to be able to enable the `verify_message` feature on `objc`.
-unsafe impl objc::Encode for NSOperatingSystemVersion {
-    fn encode() -> objc::Encoding {
-        unsafe { objc::Encoding::from_str("{?=qqq}") }
-    }
+/// runtime.
+unsafe impl Encode for NSOperatingSystemVersion {
+    const ENCODING: Encoding = Encoding::Struct(
+        "NSOperatingSystemVersion",
+        &[Encoding::LongLong, Encoding::LongLong, Encoding::LongLong],
+    );
+}
+
+unsafe impl RefEncode for NSOperatingSystemVersion {
+    const ENCODING_REF: Encoding = Encoding::Pointer(&Self::ENCODING);
 }
 
 /// Authorization status of the Mullvad daemon.

mullvad-daemon/src/macos_launch_daemon.rs

@@ -567,7 +567,7 @@ mod test {
             msg.contains('\n'),
             "Message does not contain a newline!! Make sure to add a newline to '{msg}'"
         );
-        let (stdout_read, mut stdout_write) = simplex(msg.as_bytes().len());
+        let (stdout_read, mut stdout_write) = simplex(msg.len());
         //  "print" to "stdout" after `duration`.
         tokio::spawn(async move {
             tokio::time::sleep(lag).await;

talpid-core/src/split_tunnel/macos/process.rs

@@ -208,8 +208,7 @@ impl SystemdResolved {
                     let parts = contents.trim().split(' ');
                     parts
                         .map(str::parse::<IpAddr>)
-                        .map(|maybe_ip| maybe_ip.map(|addr| addr.is_loopback()).unwrap_or(false))
-                        .any(|is_loopback| is_loopback)
+                        .any(|maybe_ip| maybe_ip.map(|addr| addr.is_loopback()).unwrap_or(false))
                 })
                 .unwrap_or(false);
 

talpid-dbus/src/systemd_resolved.rs

@@ -159,12 +159,12 @@ impl SocksAuth {
     /// assert!(too_long_username.is_err());
     /// ```
     pub fn new(username: String, password: String) -> Result<Self, Error> {
-        if !(1..=255).contains(&password.as_bytes().len()) {
+        if !(1..=255).contains(&password.len()) {
             return Err(Error::InvalidSocksAuthValues(
                 "Password length should between 1 and 255 bytes",
             ));
         }
-        if !(1..=255).contains(&username.as_bytes().len()) {
+        if !(1..=255).contains(&username.len()) {
             return Err(Error::InvalidSocksAuthValues(
                 "Username length should between 1 and 255 bytes",
             ));