From d5061a2e30f20d049c8d748770e6e50d5c870697 Mon Sep 17 00:00:00 2001
From: Jon Petersson <jon.petersson@kvadrat.se>
Date: Tue, 5 Sep 2023 12:18:23 +0200
Subject: [PATCH] Fix Swiftlint warnings in LocationDataSource

---
 .../SelectLocation/LocationDataSource.swift   | 105 ++++++++++--------
 1 file changed, 59 insertions(+), 46 deletions(-)

diff --git a/ios/MullvadVPN/View controllers/SelectLocation/LocationDataSource.swift b/ios/MullvadVPN/View controllers/SelectLocation/LocationDataSource.swift
index 3ee5e3245250..ee5efa3d2497 100644
--- a/ios/MullvadVPN/View controllers/SelectLocation/LocationDataSource.swift	
+++ b/ios/MullvadVPN/View controllers/SelectLocation/LocationDataSource.swift	
@@ -75,14 +75,11 @@ final class LocationDataSource: UITableViewDiffableDataSource<Int, RelayLocation
 
     func setRelays(_ response: REST.ServerRelaysResponse) {
         let rootNode = Self.makeRootNode()
-        var nodeByLocation = [RelayLocation: Node]()
+        nodeByLocation.removeAll()
 
         for relay in response.wireguard.relays {
-            guard case let .city(
-                countryCode,
-                cityCode
-            ) = RelayLocation(dashSeparatedString: relay.location),
-                let serverLocation = response.locations[relay.location] else { continue }
+            guard case let .city(countryCode, cityCode) = RelayLocation(dashSeparatedString: relay.location),
+                  let serverLocation = response.locations[relay.location] else { continue }
 
             let relayLocation = RelayLocation.hostname(countryCode, cityCode, relay.hostname)
 
@@ -92,52 +89,21 @@ final class LocationDataSource: UITableViewDiffableDataSource<Int, RelayLocation
                 }
 
                 // Maintain the `showsChildren` state when transitioning between relay lists
-                let wasShowingChildren = nodeByLocation[ascendantOrSelf]?
-                    .showsChildren ?? false
-
-                let node: Node
-                switch ascendantOrSelf {
-                case .country:
-                    node = Node(
-                        type: .country,
-                        location: ascendantOrSelf,
-                        displayName: serverLocation.country,
-                        showsChildren: wasShowingChildren,
-                        isActive: true,
-                        children: []
-                    )
-                    rootNode.addChild(node)
-
-                case let .city(countryCode, _):
-                    node = Node(
-                        type: .city,
-                        location: ascendantOrSelf,
-                        displayName: serverLocation.city,
-                        showsChildren: wasShowingChildren,
-                        isActive: true,
-                        children: []
-                    )
-                    nodeByLocation[.country(countryCode)]!.addChild(node)
-
-                case let .hostname(countryCode, cityCode, _):
-                    node = Node(
-                        type: .relay,
-                        location: ascendantOrSelf,
-                        displayName: relay.hostname,
-                        showsChildren: false,
-                        isActive: relay.active,
-                        children: []
-                    )
-                    nodeByLocation[.city(countryCode, cityCode)]!.addChild(node)
-                }
-
+                let wasShowingChildren = nodeByLocation[ascendantOrSelf]?.showsChildren ?? false
+
+                let node = createNode(
+                    ascendantOrSelf: ascendantOrSelf,
+                    serverLocation: serverLocation,
+                    relay: relay,
+                    rootNode: rootNode,
+                    wasShowingChildren: wasShowingChildren
+                )
                 nodeByLocation[ascendantOrSelf] = node
             }
         }
 
         rootNode.sortChildrenRecursive()
         rootNode.computeActiveChildrenRecursive()
-        self.nodeByLocation = nodeByLocation
         locationList = rootNode.flatRelayLocationList()
 
         filterRelays(by: currentSearchString)
@@ -192,6 +158,53 @@ final class LocationDataSource: UITableViewDiffableDataSource<Int, RelayLocation
         }
     }
 
+    private func createNode(
+        ascendantOrSelf: RelayLocation,
+        serverLocation: REST.ServerLocation,
+        relay: REST.ServerRelay,
+        rootNode: Node,
+        wasShowingChildren: Bool
+    ) -> Node {
+        let node: Node
+
+        switch ascendantOrSelf {
+        case .country:
+            node = Node(
+                type: .country,
+                location: ascendantOrSelf,
+                displayName: serverLocation.country,
+                showsChildren: wasShowingChildren,
+                isActive: true,
+                children: []
+            )
+            rootNode.addChild(node)
+
+        case let .city(countryCode, _):
+            node = Node(
+                type: .city,
+                location: ascendantOrSelf,
+                displayName: serverLocation.city,
+                showsChildren: wasShowingChildren,
+                isActive: true,
+                children: []
+            )
+            nodeByLocation[.country(countryCode)]!.addChild(node)
+
+        case let .hostname(countryCode, cityCode, _):
+            node = Node(
+                type: .relay,
+                location: ascendantOrSelf,
+                displayName: relay.hostname,
+                showsChildren: false,
+                isActive: relay.active,
+                children: []
+            )
+            nodeByLocation[.city(countryCode, cityCode)]!.addChild(node)
+        }
+
+        return node
+    }
+
     private func updateDataSnapshot(
         with locations: [RelayLocation],
         reloadExisting: Bool = false,