Fix voucher dialog margins #5152
Conversation
IOS-308 Voucher submission dialog should use the same margins as other info dialogs
https://mullvad.slack.com/archives/C052D9X882U/p1694419482421749 Zeplin should have all the dimensions needed for this. |
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/UI appearance/UIMetrics.swift line 41 at r1 (raw file):
static let cornerRadius = 8.0 static let preferredContentSize = CGSize(width: 280, height: 260) static let contentLayoutMargins = NSDirectionalEdgeInsets(top: 16, leading: 16, bottom: 16, trailing: 16)
we have RedeemVoucherViewConfiguration for having diffrent properties for voucher view appearance in account flow or profile.please addd directionalLayoutMargins property into RedeemVoucherViewConfiguration and set different values for them from their coordinators:
**import** Foundation
**import** UIKit
**struct** RedeemVoucherViewConfiguration {
**let** adjustViewWhenKeyboardAppears: Bool
**let** directionalLayoutMargins : NSDirectionalEdgeInsets
}
then in CreateAccountVoucherCoordinator set UIMetrics.contentLayoutMargins and in
ProfileVoucherCoordinator set the custom alert margin
rablador
force-pushed
the
voucher-submission-dialog-should-use-the-same-margins-as-ios-308
branch
from
738e9bb to
c51a2a6
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/UI appearance/UIMetrics.swift line 41 at r1 (raw file):
Previously, mojganii wrote…
we have
RedeemVoucherViewConfigurationfor having diffrent properties for voucher view appearance in account flow or profile.please addddirectionalLayoutMarginsproperty intoRedeemVoucherViewConfigurationand set different values for them from their coordinators:**import** Foundation **import** UIKit **struct** RedeemVoucherViewConfiguration { **let** adjustViewWhenKeyboardAppears: Bool **let** directionalLayoutMargins : NSDirectionalEdgeInsets }then in
CreateAccountVoucherCoordinatorsetUIMetrics.contentLayoutMarginsand in
ProfileVoucherCoordinatorset the custom alert margin
Done.
rablador
force-pushed
the
voucher-submission-dialog-should-use-the-same-margins-as-ios-308
branch
from
c51a2a6 to
71d4e16
Compare
rablador
deleted the
voucher-submission-dialog-should-use-the-same-margins-as-ios-308
branch
Voucher submission dialog should use the same margins as other info dialogs.
See: https://mullvad.slack.com/archives/C052D9X882U/p1694419482421749
This change is