Querying the outgoing connection IP should not affect the in IP #5572
Conversation
rablador
requested review from
mojganii and
buggmagnet
and removed request for
mojganii
rablador
force-pushed
the
querying-the-outgoing-connection-ip-should-not-affect-the-in-ios-409
branch
from
0030a8e to
fc6bc43
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/View controllers/Tunnel/TunnelControlViewModel.swift line 62 at r1 (raw file):
} extension TunnelControlViewModel {
We don't need to add an extension here, it's in the same file.
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/View controllers/Tunnel/TunnelControlViewModel.swift line 62 at r1 (raw file):
Previously, buggmagnet wrote…
We don't need to add an extension here, it's in the same file.
Just thought it looked neater since it's public and somewhat different in its use. I can revert.
rablador
force-pushed
the
querying-the-outgoing-connection-ip-should-not-affect-the-in-ios-409
branch
from
fc6bc43 to
3115ad0
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
deleted the
querying-the-outgoing-connection-ip-should-not-affect-the-in-ios-409
branch
If the connection is slow, the In IP address won't be updated until we are done querying the Out addresses. We should:
getOutgoingConnectionInfoshould not fail if IPv4 succeeded but IPv6 threw).This change is